Automatic edit point bookmarks following crop

[af123]

Here are the proposed changes based on Matthew's posted patches earlier:

Automatic edit point bookmarks following crop by hummypkg · Pull Request #1 · hummypkg/webif

github.com

(@Black Hole - you can fetch a patch from https://github.com/hummypkg/webif/pull/1.patch should you wish)

 

[Black Hole]

It's a lot simpler if I just wait for the push!

 

[Matthew]

That's less of a mystery than why the capital M!

What M?

 

[Black Hole]

What M?

From:

I don't understand why ls lists the mods file with an initial capital.

 

[af123]

From:

That makes absolutely no sense!

 

[af123]

I am happy for this, or any of my mods to be incorporated into the webif.

@Matthew - please can you look over the proposed change based on your work? I've updated it this morning, simplifying things a bit - calculating the new bookmarks in the same pass as the cut points are determined, removed some duplication in the javascript by using .trigger('click'), and also cleaned up my old $.get calls to escape things properly. Thanks.

Automatic edit point bookmarks following crop by hummypkg · Pull Request #1 · hummypkg/webif

github.com

 

[Black Hole]

Now what!!!



Click OPT+... Crop gets:



...then click "Perform crop operation" gets immediately:



...with nothing done.

 

[af123]

Any better if you toggle 'Save new bookmarks' off first?

 

[Black Hole]

That does nothing either. Maybe there's something not installed on this particular machine? Note it's a HD-FOX, and the recording has been decrypted.

 

[Trev]

Is it my imagination (or ignorance) or is that crop sequence going to keep the ads and bin the good stuff?

 

[Black Hole]

ignorance

Yes

These are the actual dances within Saturday's Strictly. The crop is keeping the "good stuff" and cutting the crap.

 

[Trev]

Crumbs. When you look at it like that, there is a whole lot of crap involved.
Also, just realised that there ain't no ads in strictly.

 

[MymsMan]

Have you successfully cropped since the latest webif update or is this the first attempt?

As usual anything in browser console log or webif-error.log ?

 

[MymsMan]

Have you successfully cropped since the latest webif update or is this the first attempt?

As usual anything in browser console log or webif-error.log ?

Answering my own question, webif-error.log

4    at file "/mod/webif/html/browse/bookmarks/save.jim", line 18
3    /mod/webif/html/browse/bookmarks/save.jim:18: Error: invalid command name "0"
2    at file "/mod/webif/html/browse/crop/execute.jim", line 20
1    /mod/webif/html/browse/crop/execute.jim:20: Error: invalid command name "0"

 

[Black Hole]

Does that mean AF's broken it?

Note I was doing this on a "virgin" unit so there was no risk of previous hand mods affecting anything.

 

[MymsMan]

Does that mean AF's broken it?

You may think that, I couldn't possibly comment

 

[af123]

You may think that, I couldn't possibly comment

I can have a look later, it's a beta : )
I did test it and didn't have any problems with doing simple crops but something must be wrong..

 

[prpr]

There are lots of places that make calls like [ts fetch $file]
This can return 0 and the result is not always error checked before then using it in a subsequent call to another method which then crashes.
Also, here are some files which perform the operation twice, seemingly pointlessly:
/mod/webif/html/browse/enc.jim
/mod/webif/html/browse/new.jim
/mod/webif/html/browse/lock.jim