Did I miss something ? Are you referring to the stuff coming out of Beta ?
Yes, the Visual Schedule date problem was identified and fixed during the beta so it would appear that @Last.To.Know has some, but not all, of the update and needs to 'Upgrade all packages' on the Packages page to complete the update.
Clicked the Upgrade all packages button.
/go/ route so that plugins can re-route requests or add their own. Nothing has changed there recently.? on the final URL that's causing you problems? That's only the query string so should be the same as the first URL.
Well, it's only made itself known this week.
Fixed it.
Looking at
/mod/webif/html/browse/script.js l.428var menuclick = function(action, el, pos)
{
var file = $(el).parent().prevAll('a.bf').last().attr('file');
var efile = encodeURIComponent(file);
...
switch (action)
{
...
default:
if (plugins.menu[action])
plugins.menu[action](file);
else
alert('Unhandled action: ' + action);
break;
}
}/mod/webif/plugin/sidecar/browse.js:...
// Action taken when 'sidecar' action clicked on native recording.
plugins.menu.sidecar = function(file) {
window.location = '/plugin/sidecar/web/?file=' + file;
....?menuclick() functions in /mod/webif/html/browse/script.js pass encodeURIComponent(file) rather than file? Or are plugins at fault for not calling encodeURIComponent() on the filename passed to them?chmod +x /mod/webif/plugin/detectads/web/runnow.jimfile parameter of the various plugin APIs is anything other than a system file name, so a plugin that wants to use it as part of a URI ought to sanitise it first, as below:...
// Action taken when [whichever plugin] action clicked on native recording.
plugins.menu.whichever = function(file) {
window.location = '/plugin/whichever/web/?file=' + encodeURIComponent(file);
...
humax /mnt/hd2/mod/webif/html/sched/rpc # diff info.jim~ info.jim
--- info.jim~
+++ info.jim
@@ -68,7 +68,7 @@
</tr>
"
-set crid [join [lrange [split [$event get szCRID] /] 1 end]]
+set crid [join [lrange [split [$event get szCRID] /] 1 end] /]
if {$crid != ""} {
puts "<tr><th>"
if {[$event isseries]} { puts "Series" } else { puts "Event" }
@@ -88,7 +88,7 @@
set ev [string range $ev 1 end]
if {$flag} { puts "<br>" }
incr flag
- set crid [join [lrange [split $ev /] 1 end]]
+ set crid [join [lrange [split $ev /] 1 end] /]
puts -nonewline "<a href=/cgi-bin/epg/search.jim?"
puts "crid=/$crid>
<img border=0 src=/images/421_1_00_CH_Title_2R_Arrow.pngIt's not completely obvious, but as I also wanted this improvement I had a look.
webif/html/sched/backup/index.jim and script changes webif/html/sched/backup/script.js to show/hide the new button and reselect the viewed item together with enabled Restore and Delete buttons after clicking 'View' (alternatively, you could morph the View button).--- index.jim.org
+++ index.jim
@@ -51,6 +51,7 @@
<button id=restore_button disabled>Restore Backup</button>
<button id=delete_button disabled>Delete Backup</button>
<button id=view_button disabled>View Backup</button>
+ <button id=close_view_button disabled>Close View</button>
<br>
<div id=restore_working class=va style="display: none;">
<img class=va src=/img/spin.gif> $() function essentially maps over the results of the DOM function document.querySelectorAll(), which <input> element with class restore whose value is the name displayed next to the radio button. Thus the item being viewed can be found using a CSS attribute selector input.restore[value=selectedItemValue].load method when loading the backup list. By doing it right, selection of a different backup while displaying the view of a backup can also be handled (closes the view), and the backup selection is retained as long as it makes sense and isn't changed.--- script.js.org
+++ script.js
@@ -1,14 +1,37 @@
-function refresh_backup_files()
+function refresh_backup_files(viewing)
{
- $('#restore_button,#delete_button,#view_button')
+ $('#restore_button,#delete_button,#view_button,#close_view_button')
.button('option', 'disabled', true);
+ $('#close_view_button').hide();
+ var backup=$('input.restore:checked').val();
$('#backup_files').load('backup/files.jim', function() {
- $('input.restore').change(function() {
+ if (backup) backup=$('input.restore[value="'+backup+'"]').val();
+ if (!backup) {
+ $('input.restore').change(function() {
$('#restore_button,#delete_button,#view_button')
.removeAttr('disabled')
.button('option', 'disabled', false);
- });
+ });
+ } else {
+ $('input.restore[value="'+backup+'"]').prop('checked',true);
+ $('#restore_button,#delete_button')
+ .removeAttr('disabled')
+ .button('option', 'disabled', false);
+ }
+ if (viewing) {
+ $('#close_view_button')
+ .removeAttr('disabled')
+ .button('option', 'disabled', false)
+ .show();
+ $('input.restore').change(function() {
+ $('#close_view_button').click();
+ });
+ } else if (backup) {
+ $('#view_button')
+ .removeAttr('disabled')
+ .button('option', 'disabled', false);
+ }
});
}
@@ -19,6 +42,7 @@
$('#restore_button').button({icons: {primary: "ui-icon-play"}});
$('#delete_button').button({icons: {primary: "ui-icon-trash"}});
$('#view_button').button({icons: {primary: "ui-icon-script"}});
+$('#close_view_button').button({icons: {primary: "ui-icon-script"}});
refresh_backup_files();
@@ -49,9 +73,13 @@
$('#backup_results').load('backup/view.jim?' +
$('input.restore').serialize(), function() {
$('#backup_results').slideDown(function() {
- refresh_backup_files();
+ refresh_backup_files(true);
});
});
+});
+$('#close_view_button').click(function() {
+ $('#backup_results').slideUp();
+ refresh_backup_files();
});
$('#restore_button').click(function() {
var backup = $('input.restore:checked').val();| 24 | /mod/webif/lib/queue.class:210: Error: no such table: queue |
| 25 | in procedure 'entry' called at file "/mod/webif/html/browse/index.jim", line 330 |
| 26 | in procedure 'queue' called at file "/mod/webif/html/browse/index.jim", line 215 |
| 27 | at file "/mod/webif/lib/queue.class", line 210 |